Tests for multi choice value #2872

DariaBod · 2026-02-05T18:55:35Z

Rationale

Some changes to support multi choice

Related Pull Requests

Tests for multi choice value#1971

Changes

Added setAllowMultipleSelections method to check “Allow multiple selections” checkbox 
Changed method initFilterColumn for work with filters for List values 
Added method testMultiChoiceValues() to ListTest (scope: create, edit) 
Created new shuffleSelect() for random amount of random values from list 
Changed method selectOptionByText() for multi choice values. If we need value to be selected we first check if it’s selected and then click

- SMProAssayCreateTest.testAddResultFields - SMSampleCreateTest.testSamplesWithMultiChoice - SMSourceTypeMultiChoiceTest - ListTest.testMultiChoiceValues

…ag() fix test testMultiChoiceEditInBulk()

-add new shuffleSelect -replace my method with shuffleSelect

labkey-danield

Added a few comments.

labkey-danield · 2026-02-09T17:11:38Z

src/org/labkey/test/components/domain/DomainFormPanel.java

+                    if(textChoiceValidator.getMultipleSelections())
+                    {
+                        fieldRow.setAllowMultipleSelections(textChoiceValidator.getMultipleSelections());
+                    }


This will only set it if textChoiceValidator.getMultipleSelections is true, correct? This is ok if you are creating a field, but wouldn't work as expected if the test is editing an existing field and wants to change to field from a multi-choice to a single choice.
Perhaps a better check would be:
if(null != textChoiceValidator.getMultipleSelections())

labkey-danield · 2026-02-09T17:21:25Z

src/org/labkey/test/components/ui/grids/EditableGrid.java

+            lookupSelect.clearSelection();
+


Will this work if a test is trying to add to an existing selections?

labkey-tchad · 2026-02-06T22:20:51Z

src/org/labkey/test/components/domain/DomainFormPanel.java

+                    if(textChoiceValidator.getMultipleSelections())
+                    {
+                        fieldRow.setAllowMultipleSelections(textChoiceValidator.getMultipleSelections());
+                    }


This would make it impossible to disable multi-select through this method.
This should either call setAllowMultipleSelections unconditionally or the condition should check whether textChoiceValidator.getMultipleSelections() != null.

labkey-tchad · 2026-02-06T22:50:02Z

src/org/labkey/test/components/ui/search/FilterFacetedPanel.java

+    /**
+     * Select a single facet value by clicking its label. Should replace all existing selections.
+     * @param value desired value
+     */
+    public void selectFilter(String value)
+    {
+        elementCache().filterTypeSelects.select(value);
+    }


Update this comment to describe this method (looks leftover from the selectValue). The comment should also mention that this is only relevant to multi-value text choice fields.

This could also take a Filter.Operator instead of a String for some extra type-safety.

labkey-tchad · 2026-02-06T23:10:59Z

src/org/labkey/test/components/ui/grids/ResponsiveGrid.java

                List<String> values = (List<String>) value;
                filterModal.selectFacetTab().selectValue(values.get(0));
                filterModal.selectFacetTab().checkValues(values.toArray(String[]::new));
+                filterModal.selectFacetTab().selectFilter(operator.getDisplayValue());


I think this will (or could) break functionality for other column types; the facet panel usually doesn't have a filter type.
Also, this wouldn't work for "Is Empty" or "Is Not Empty".

I’m planning to add support for 'Is Empty' and 'Is Not Empty' as well.

Regarding the functionality for other types: I’ve already found one test that was failing, so I added a check to the initFilterColumn method. It now checks if the filter type selector is present on the page before trying to interact with it. After this change, the test is passing.

Does this approach sound okay to you?

src/org/labkey/test/pages/query/UpdateQueryRowPage.java

labkey-tchad · 2026-02-07T00:25:25Z

src/org/labkey/test/pages/DatasetInsertPage.java

        for (Map.Entry<String, String> entry : values.entrySet())
        {
-            WebElement fieldInput = Locator.name(EscapeUtil.getFormFieldName(entry.getKey())).findElement(getDriver());
+            WebElement fieldInput = Locator.nameContaining(EscapeUtil.getFormFieldName(entry.getKey())).findElement(getDriver());


Use a more precise locator and add a comment explaining why this can't match the name exactly. (See UpdateQueryRowPage)

labkey-tchad · 2026-02-07T00:42:31Z

src/org/labkey/test/tests/list/ListTest.java

+        table.clickInsertNewRow();
+        String valuesToChoose = tcValues.subList(1, 3).stream()
+                .sorted()
+                .collect(Collectors.joining(" "));
+        Locator loc = Locator.nameContaining(EscapeUtil.getFormFieldName(columnName));
+        selectOptionByText(loc, valuesToChoose);


clickInsertNewRow returns a page object that should have methods for setting fields.

labkey-tchad · 2026-02-09T18:10:23Z

src/org/labkey/test/tests/list/ListTest.java

+        String encodedListName = "multiChoiceList";
+        String keyName = "'><script>alert(\":(\")</script>'";
+        String columnName = "MultiChoiceField";


Consider using randomly generated field and list names. (I'm not sure whether ListHelper can handle the tricky characters but it's worth a try)

Suggested change

String encodedListName = "multiChoiceList";

String keyName = "'><script>alert(\":(\")</script>'";

String columnName = "MultiChoiceField";

String encodedListName = TestDataGenerator.randomDomainName("multiChoiceList", DomainUtils.DomainKind.IntList);

String keyName = TestDataGenerator.randomFieldName("'><script>alert(\":(\")</script>'");

String columnName = TestDataGenerator.randomFieldName("MultiChoiceField");

labkey-tchad · 2026-02-09T18:15:30Z

src/org/labkey/test/tests/list/ListTest.java

+        selectOptionByText(loc, valuesToChoose);
+
+        clickButton("Submit");
+        checker().verifyEquals("Multi choice value not as expected", valuesToChoose, table.getDataAsText(0, columnName));


checker() doesn't take screenshots automatically. If you're doing a single check, checker().withScreenshot().verifyX will trigger a failure screenshot. If you're doing several checks, you should call checker().screenShotIfNewError(); after the checks.

Suggested change

checker().verifyEquals("Multi choice value not as expected", valuesToChoose, table.getDataAsText(0, columnName));

checker().withScreenshot().verifyEquals("Multi choice value not as expected", valuesToChoose, table.getDataAsText(0, columnName));

labkey-tchad · 2026-02-09T18:15:59Z

src/org/labkey/test/tests/list/ListTest.java

+        clickButton("Submit");
+
+        // verify the multi choice value is persisted
+        checker().verifyEquals("Multi choice value not as expected", valuesToChoose, table.getDataAsText(0, columnName));


Take a screenshot.

Suggested change

checker().verifyEquals("Multi choice value not as expected", valuesToChoose, table.getDataAsText(0, columnName));

checker().withScreenshot().verifyEquals("Multi choice value not as expected", valuesToChoose, table.getDataAsText(0, columnName));

labkey-tchad · 2026-02-09T18:41:07Z

src/org/labkey/test/WebDriverWrapper.java

+        if(Boolean.parseBoolean(selectElement.getAttribute("multiple"))) {
+            List<WebElement> elems = selectElement.findElements(Locator.tag("option"));
+            elems.forEach(element->{
+                if(value.contains(element.getAttribute("value")) ^ element.isSelected()) element.click();
+            });
+            return;
+        }


This is less precise than we like for broadly available helpers; it would get confused by selection options that have overlapping text. I would suggest having a separate method for multi-select (selectOptionsByText(WebElement selectElement, List<String> values).

labkey-tchad · 2026-02-09T18:48:02Z

src/org/labkey/test/tests/list/ListTest.java

+    public void testMultiChoiceValues()
+    {


We should only run the test on Postgres.

Suggested change

public void testMultiChoiceValues()

{

public void testMultiChoiceValues()

{

Assume.assumeTrue("Multi-choice text fields are only supported on PostgreSQL", WebTestHelper.getDatabaseType() == WebTestHelper.DatabaseType.PostgreSQL);

Co-authored-by: Trey Chadick <tchad@labkey.com>

- Test fixes for change from quoted values to bold in error messages

getConversionErrorMessage() fix to message case for invalid date/timestamp now quoting field name for consistency

DariaBod added 10 commits January 23, 2026 13:40

initial commit for multichoice value

333c490

some changes

fabe096

add tests for:

349d08d

- SMProAssayCreateTest.testAddResultFields - SMSampleCreateTest.testSamplesWithMultiChoice - SMSourceTypeMultiChoiceTest - ListTest.testMultiChoiceValues

Merge branch 'develop' into fb_mvtc_test

0ab67be

new changes for test

fd9d700

Merge branch 'develop' into fb_mvtc_test

bf42d09

Merge branch 'develop' into fb_mvtc_test

1745585

add test testMultiChoiceUpdateFromFile(), testMultiChoiceEditInGridDr…

f349d82

…ag() fix test testMultiChoiceEditInBulk()

Merge branch 'develop' into fb_mvtc_test

92000dd

Merge branch 'develop' into fb_mvtc_test

c3c8266

DariaBod changed the title ~~Fb mvtc test~~ Tests for multi choice value Feb 5, 2026

DariaBod requested a review from labkey-danield February 5, 2026 19:10

DariaBod added 2 commits February 5, 2026 11:13

-delete unused imports

e5ec9db

-delete unexpected symbol

33683e0

LabKey deleted a comment from github-actions bot Feb 5, 2026

-some code style fixes

9a5773a

-add new shuffleSelect -replace my method with shuffleSelect

DariaBod requested a review from labkey-tchad February 5, 2026 23:18

labkey-danield reviewed Feb 9, 2026

View reviewed changes

labkey-tchad reviewed Feb 9, 2026

View reviewed changes

DariaBod and others added 9 commits February 10, 2026 16:58

Apply suggestion from @labkey-tchad

41e1c78

Co-authored-by: Trey Chadick <tchad@labkey.com>

Provide warnings for unknown fields for cross sample type import (#2862)

36a970a

- Test fixes for change from quoted values to bold in error messages

Dismiss popover for responsive grid (#2874)

bac1f69

Misc fixes for error message single quote change (#2876)

c44cbd6

getConversionErrorMessage() fix to message case for invalid date/timestamp now quoting field name for consistency

Fix expected error messages in tests (#2875)

c60c514

Fix build: remove import in ListDateAndTimeTest (#2879)

fe04f1f

Updating SampleFinder Test Component (#2877)

0435138

fix comments about selectFilter javadoc and initFilterColumn method

b4d52e0

Merge branch 'develop' into fb_mvtc_test

fd83f85

	checker().verifyEquals("Multi choice value not as expected", valuesToChoose, table.getDataAsText(0, columnName));
	checker().withScreenshot().verifyEquals("Multi choice value not as expected", valuesToChoose, table.getDataAsText(0, columnName));

Tests for multi choice value #2872

Are you sure you want to change the base?

Tests for multi choice value #2872

Conversation

DariaBod commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale

Related Pull Requests

Changes

Uh oh!

labkey-danield left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

DariaBod commented Feb 5, 2026 •

edited

Loading